Add unit tests for AZ-aware struct and schema changes#480
Conversation
|
Hi @abhiramnarayana. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
abhiramnarayana
force-pushed
the
osprh-30644-unit-tests
branch
2 times, most recently
from
f9a4ec7 to
fe1b78f
Compare
omersch381
left a comment
omersch381
left a comment
There was a problem hiding this comment.
I left a comment regarding one of the tests name, but except for that, it LGTM
| } | ||
| } | ||
|
|
||
| func TestGenerateMultiplePoolsWithViewAndTSIG(t *testing.T) { |
There was a problem hiding this comment.
This test does not include tsig keys.
abhiramnarayana
force-pushed
the
osprh-30644-unit-tests
branch
from
fe1b78f to
705354d
Compare
|
recheck |
Add tests to generate_bind9_pools_yaml_test.go verifying the data
model and validation changes for AZ-aware multipool support protect
against regressions. Covers view propagation to generated pool targets,
template rendering of view and tsigkey_id fields (both inclusion
when set and omission when empty), and AZ mode validation across
all three enum states ("", "Disabled", "Enabled").
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Abhiram R N <abhiramrn@gmail.com>
abhiramnarayana
force-pushed
the
osprh-30644-unit-tests
branch
from
705354d to
1bb46d0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhiramnarayana, omersch381 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit ee6be66
into
openstack-k8s-operators:main
2 participants
Add tests to generate_bind9_pools_yaml_test.go verifying the data model and validation changes for AZ-aware multipool support protect against regressions. Covers view propagation to generated pool targets, template rendering of view and tsigkey_id fields (both inclusion when set and omission when empty), and AZ mode validation across all three enum states ("", "Disabled", "Enabled").